lkml.org 
[lkml]   [2022]   [Aug]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH v3 10/14] iio: ad7476: simplify using devm_regulator_get_enable()
    Drop open-coded pattern: 'devm_regulator_get(), regulator_enable(),
    add_action_or_reset(regulator_disable)' and use the
    devm_regulator_get_enable()

    Signed-off-by: Matti Vaittinen <mazziesaccount@gmail.com>

    ---
    v2 => v3:
    New patch
    ---
    drivers/iio/adc/ad7476.c | 11 +----------
    1 file changed, 1 insertion(+), 10 deletions(-)

    diff --git a/drivers/iio/adc/ad7476.c b/drivers/iio/adc/ad7476.c
    index 94776f696290..80aebed47d1f 100644
    --- a/drivers/iio/adc/ad7476.c
    +++ b/drivers/iio/adc/ad7476.c
    @@ -368,16 +368,7 @@ static int ad7476_probe(struct spi_device *spi)
    }

    if (st->chip_info->has_vdrive) {
    - reg = devm_regulator_get(&spi->dev, "vdrive");
    - if (IS_ERR(reg))
    - return PTR_ERR(reg);
    -
    - ret = regulator_enable(reg);
    - if (ret)
    - return ret;
    -
    - ret = devm_add_action_or_reset(&spi->dev, ad7476_reg_disable,
    - reg);
    + ret = devm_regulator_get_enable(&spi->dev, "vdrive");
    if (ret)
    return ret;
    }
    --
    2.37.1

    --
    Matti Vaittinen, Linux device drivers
    ROHM Semiconductors, Finland SWDC
    Kiviharjunlenkki 1E
    90220 OULU
    FINLAND

    ~~~ "I don't think so," said Rene Descartes. Just then he vanished ~~~
    Simon says - in Latin please.
    ~~~ "non cogito me" dixit Rene Descarte, deinde evanescavit ~~~
    Thanks to Simon Glass for the translation =]
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2022-08-19 21:21    [W:4.097 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site