lkml.org 
[lkml]   [2022]   [Aug]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRE: [PATCH v3 11/14] iio: ad7606: simplify using devm_regulator_get_enable()
    Date
    > From: Matti Vaittinen <mazziesaccount@gmail.com>
    > Sent: Friday, August 19, 2022 9:20 PM
    > To: Matti Vaittinen <mazziesaccount@gmail.com>; Matti Vaittinen
    > <matti.vaittinen@fi.rohmeurope.com>
    > Cc: Lars-Peter Clausen <lars@metafoo.de>; Hennerich, Michael
    > <Michael.Hennerich@analog.com>; Jonathan Cameron
    > <jic23@kernel.org>; linux-iio@vger.kernel.org; linux-
    > kernel@vger.kernel.org
    > Subject: [PATCH v3 11/14] iio: ad7606: simplify using
    > devm_regulator_get_enable()
    >
    > [External]
    >
    > Drop open-coded pattern: 'devm_regulator_get(), regulator_enable(),
    > add_action_or_reset(regulator_disable)' and use the
    > devm_regulator_get_enable() and drop the pointer to the regulator.
    > This simplifies code and makes it less tempting to add manual control
    > for the regulator which is also controlled by devm.
    >
    > Signed-off-by: Matti Vaittinen <mazziesaccount@gmail.com>
    >
    > ---

    The commit message could state that while doing the change, dev_err_probe()
    was also introduced. Bah, anyways:

    Acked-by: Nuno Sá <nuno.sa@analog.com>

    \
     
     \ /
      Last update: 2022-08-30 13:47    [W:5.172 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site