lkml.org 
[lkml]   [2022]   [Aug]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v6 3/6] scsi: ufs: wb: Add explicit flush sysfs attribute
From
On 8/2/22 01:07, Jinyoung CHOI wrote:
> +What: /sys/bus/platform/drivers/ufshcd/*/wb_buf_flush_en
> +What: /sys/bus/platform/devices/*.ufs/wb_buf_flush_en
> +Date: July 2022
> +Contact: Jinyoung Choi <j-young.choi@samsung.com>
> +Description: This entry shows the status of WriteBooster buffer flushing

Can we rename this attribute into something that has a word order that
is grammatically correct, e.g. enable_wb_buf_flush?

> + and it can be used to allow or disallow the flushing.
> + If the flushing is allowed, the device executes the flush
> + operation when the command queue is empty.

The attribute has "enabled" in its name while the above text uses the
verb "allowed". Consider changing "allowed" into "enabled". Please also
change "If the flushing" into "If flushing".

Thanks,

Bart.

\
 
 \ /
  Last update: 2022-08-03 19:39    [W:0.226 / U:1.136 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site