lkml.org 
[lkml]   [2022]   [Aug]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    SubjectRe: [PATCH v6 5/6] scsi: ufs: wb: Modify messages
    Hi,

    On Tue, Aug 2, 2022 at 4:29 PM Jinyoung CHOI <j-young.choi@samsung.com> wrote:
    >
    > Messages are modified to fit the format of others.
    >
    > Reviewed-by: Avri Altman <avri.altman@wdc.com>
    > Reviewed-by: Bart Van Assche <bvanassche@acm.org>
    > Signed-off-by: Jinyoung Choi <j-young.choi@samsung.com>
    > ---
    > drivers/ufs/core/ufs-sysfs.c | 2 +-
    > drivers/ufs/core/ufshcd.c | 23 +++++++++++------------
    > 2 files changed, 12 insertions(+), 13 deletions(-)
    >
    > diff --git a/drivers/ufs/core/ufs-sysfs.c b/drivers/ufs/core/ufs-sysfs.c
    > index 2c0b7f45de4b..117272cf7d61 100644
    > --- a/drivers/ufs/core/ufs-sysfs.c
    > +++ b/drivers/ufs/core/ufs-sysfs.c
    > @@ -230,7 +230,7 @@ static ssize_t wb_on_store(struct device *dev, struct device_attribute *attr,
    > * If the platform supports UFSHCD_CAP_CLK_SCALING, turn WB
    > * on/off will be done while clock scaling up/down.
    > */
    > - dev_warn(dev, "To control WB through wb_on is not allowed!\n");
    > + dev_warn(dev, "It is not allowed to configure WB!\n");
    > return -EOPNOTSUPP;
    > }
    >
    > diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
    > index 5099d161f115..dcd7f03db2a2 100644
    > --- a/drivers/ufs/core/ufshcd.c
    > +++ b/drivers/ufs/core/ufshcd.c
    > @@ -5737,13 +5737,13 @@ int ufshcd_wb_toggle(struct ufs_hba *hba, bool enable)
    >
    > ret = __ufshcd_wb_toggle(hba, enable, QUERY_FLAG_IDN_WB_EN);
    > if (ret) {
    > - dev_err(hba->dev, "%s Write Booster %s failed %d\n",
    > - __func__, enable ? "enable" : "disable", ret);
    > + dev_err(hba->dev, "%s: Write Booster %s failed %d\n",
    > + __func__, enable ? "enabling" : "disabling", ret);
    > return ret;
    > }
    >
    > hba->dev_info.wb_enabled = enable;
    > - dev_info(hba->dev, "%s Write Booster %s\n",
    > + dev_info(hba->dev, "%s: Write Booster %s\n",
    > __func__, enable ? "enabled" : "disabled");

    You need to rebase this patch to follow the latest change as
    https://lore.kernel.org/all/20220709000027.3929970-1-bjorn.andersson@linaro.org/

    >
    > return ret;
    > @@ -5757,11 +5757,11 @@ static void ufshcd_wb_toggle_buf_flush_during_h8(struct ufs_hba *hba,
    > ret = __ufshcd_wb_toggle(hba, enable,
    > QUERY_FLAG_IDN_WB_BUFF_FLUSH_DURING_HIBERN8);
    > if (ret) {
    > - dev_err(hba->dev, "%s: WB-Buf Flush during H8 %s failed: %d\n",
    > - __func__, enable ? "enable" : "disable", ret);
    > + dev_err(hba->dev, "%s: WB-Buf Flush during H8 %s failed %d\n",
    > + __func__, enable ? "enabling" : "disabling", ret);
    > return;
    > }
    > - dev_dbg(hba->dev, "%s WB-Buf Flush during H8 %s\n",
    > + dev_info(hba->dev, "%s: WB-Buf Flush during H8 %s\n",
    > __func__, enable ? "enabled" : "disabled");
    > }
    >
    > @@ -5775,14 +5775,13 @@ int ufshcd_wb_toggle_buf_flush(struct ufs_hba *hba, bool enable)
    >
    > ret = __ufshcd_wb_toggle(hba, enable, QUERY_FLAG_IDN_WB_BUFF_FLUSH_EN);
    > if (ret) {
    > - dev_err(hba->dev, "%s WB-Buf Flush %s failed %d\n", __func__,
    > - enable ? "enable" : "disable", ret);
    > + dev_err(hba->dev, "%s: WB-Buf Flush %s failed %d\n",
    > + __func__, enable ? "enabling" : "disabling", ret);
    > return ret;
    > }
    >
    > hba->dev_info.wb_buf_flush_enabled = enable;
    > -
    > - dev_dbg(hba->dev, "%s WB-Buf Flush %s\n",
    > + dev_info(hba->dev, "%s: WB-Buf Flush %s\n",
    > __func__, enable ? "enabled" : "disabled");
    >
    > return ret;
    > @@ -5800,7 +5799,7 @@ static bool ufshcd_wb_presrv_usrspc_keep_vcc_on(struct ufs_hba *hba,
    > QUERY_ATTR_IDN_CURR_WB_BUFF_SIZE,
    > index, 0, &cur_buf);
    > if (ret) {
    > - dev_err(hba->dev, "%s dCurWriteBoosterBufferSize read failed %d\n",
    > + dev_err(hba->dev, "%s: dCurWriteBoosterBufferSize read failed %d\n",
    > __func__, ret);
    > return false;
    > }
    > @@ -5885,7 +5884,7 @@ static bool ufshcd_wb_need_flush(struct ufs_hba *hba)
    > QUERY_ATTR_IDN_AVAIL_WB_BUFF_SIZE,
    > index, 0, &avail_buf);
    > if (ret) {
    > - dev_warn(hba->dev, "%s dAvailableWriteBoosterBufferSize read failed %d\n",
    > + dev_warn(hba->dev, "%s: dAvailableWriteBoosterBufferSize read failed %d\n",
    > __func__, ret);
    > return false;
    > }
    > --
    > 2.25.1



    --
    Yours truly,

    朱原陞 (Stanley Chu)

    \
     
     \ /
      Last update: 2022-08-02 16:13    [W:6.651 / U:0.460 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site