lkml.org 
[lkml]   [2022]   [Aug]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v3 3/6] drm/msm/dsi: Don't set a load before disabling a regulator
From
On 03/08/2022 01:37, Douglas Anderson wrote:
> As of commit 5451781dadf8 ("regulator: core: Only count load for
> enabled consumers"), a load isn't counted for a disabled
> regulator. That means all the code in the DSI driver to specify and
> set loads before disabling a regulator is not actually doing anything
> useful. Let's remove it.
>
> It should be noted that all of the loads set that were being specified
> were pointless noise anyway. The only use for this number is to pick
> between low power and high power modes of regulators. Regulators
> appear to do this changeover at loads on the order of 10000 uA. You
> would need a lot of clients of the same rail for that 100 uA number to
> count for anything.
>
> Note that now that we get rid of the setting of the load at disable
> time, we can just set the load once when we first get the regulator
> and then forget it.
>
> It should also be noted that the regulator functions
> regulator_bulk_enable() and regulator_set_load() already print error
> messages when they encounter problems so while moving things around we
> get rid of some extra error prints.
>
> Signed-off-by: Douglas Anderson <dianders@chromium.org>

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>

> ---
>
> Changes in v3:
> - Fix typo in commit message.
> - Just directly call the bulk commands; get rid of the wrapper.
>
> drivers/gpu/drm/msm/dsi/dsi.h | 1 -
> drivers/gpu/drm/msm/dsi/dsi_cfg.c | 52 +++++++-------
> drivers/gpu/drm/msm/dsi/dsi_host.c | 71 ++++---------------
> drivers/gpu/drm/msm/dsi/phy/dsi_phy.c | 52 ++------------
> drivers/gpu/drm/msm/dsi/phy/dsi_phy_10nm.c | 4 +-
> drivers/gpu/drm/msm/dsi/phy/dsi_phy_14nm.c | 6 +-
> drivers/gpu/drm/msm/dsi/phy/dsi_phy_20nm.c | 4 +-
> drivers/gpu/drm/msm/dsi/phy/dsi_phy_28nm.c | 6 +-
> .../gpu/drm/msm/dsi/phy/dsi_phy_28nm_8960.c | 2 +-
> drivers/gpu/drm/msm/dsi/phy/dsi_phy_7nm.c | 6 +-
> 10 files changed, 60 insertions(+), 144 deletions(-)
>


--
With best wishes
Dmitry

\
 
 \ /
  Last update: 2022-08-03 09:07    [W:0.139 / U:0.360 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site