Messages in this thread |  | | Date | Wed, 3 Aug 2022 10:02:33 +0300 | Subject | Re: [PATCH v3 2/6] drm/msm/dsi: Fix number of regulators for SDM660 | From | Dmitry Baryshkov <> |
| |
On 03/08/2022 01:37, Douglas Anderson wrote: > 1 regulators is specified listed but the number 2 is specified. This > presumably means we try to get a regulator with no name. Fix it. > > Fixes: 033f47f7f121 ("drm/msm/dsi: Add DSI configuration for SDM660") > Signed-off-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> --- > > (no changes since v2) > > Changes in v2: > - ("Fix number of regulators for SDM660") new for v2. > > drivers/gpu/drm/msm/dsi/dsi_cfg.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/msm/dsi/dsi_cfg.c b/drivers/gpu/drm/msm/dsi/dsi_cfg.c > index 02000a7b7a18..72c018e26f47 100644 > --- a/drivers/gpu/drm/msm/dsi/dsi_cfg.c > +++ b/drivers/gpu/drm/msm/dsi/dsi_cfg.c > @@ -148,7 +148,7 @@ static const char * const dsi_sdm660_bus_clk_names[] = { > static const struct msm_dsi_config sdm660_dsi_cfg = { > .io_offset = DSI_6G_REG_SHIFT, > .reg_cfg = { > - .num = 2, > + .num = 1, > .regs = { > {"vdda", 12560, 4 }, /* 1.2 V */
We should find some time and switch the reg_cfg.regs to be the external array, so that we can use ARRAY_SIZE for the amount of regs. However it is definitely not a showstopper for this series.
-- With best wishes Dmitry
|  |