Messages in this thread | | | From | Doug Anderson <> | Date | Wed, 3 Aug 2022 06:54:58 -0700 | Subject | Re: [PATCH v3 6/6] drm/msm/dsi: Improve dsi_phy_driver_probe() probe error handling |
| |
Hi,
On Wed, Aug 3, 2022 at 12:32 AM Dmitry Baryshkov <dmitry.baryshkov@linaro.org> wrote: > > > @@ -634,88 +631,71 @@ static int dsi_phy_driver_probe(struct platform_device *pdev) > > phy->cphy_mode = (phy_type == PHY_TYPE_CPHY); > > > > phy->base = msm_ioremap_size(pdev, "dsi_phy", &phy->base_size); > > - if (IS_ERR(phy->base)) { > > - DRM_DEV_ERROR(dev, "%s: failed to map phy base\n", __func__); > > - ret = -ENOMEM; > > Here (and in a few cases later) this changes the error code from crafted > -ENOMEM to the proper one returned by msm_ioremap_size(). This should be > mentioned in the commit message.
Good point. Unless something comes up I'll plan to spin a v4 with this change to the commit message tomorrow.
-Doug
| |