lkml.org 
[lkml]   [2022]   [Aug]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] usb/serial: fix repeated words in comments
On Mon, Aug 22, 2022 at 07:47:39PM +0800, 无名 wrote:
> Replace 'mode' with 'or'

This is not a proper commit message as it only says what you do, not
why. Try to spell it out.

> Signed-off-by: Jilin Yuan <yuanjilin@cdjrlc.com&gt;
> ---

Missing changelog here.

> &nbsp;drivers/usb/serial/mct_u232.h | 4 ++--
> &nbsp;1 file changed, 2 insertions(+), 2 deletions(-)

This patch is corrupt and looks like it was sent as HTML too.

Also look at the git log for this file and use the common Subject
prefix.

It's also customary to CC people that have helped review your patch.

Johan

\
 
 \ /
  Last update: 2022-08-22 14:27    [W:0.044 / U:2.288 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site