Messages in this thread | | | From | Gilad Ben-Yossef <> | Date | Sun, 21 Aug 2022 12:44:04 +0300 | Subject | Re: [PATCH v1 12/19] crypto: ccree: Fix dma_map_sg error check |
| |
Hi Jack,
On Fri, Aug 19, 2022 at 9:08 AM Jack Wang <jinpu.wang@ionos.com> wrote: > > dma_map_sg return 0 on error, and dma_map_error is not supposed to use > here. > > Cc: Gilad Ben-Yossef <gilad@benyossef.com> > Cc: Herbert Xu <herbert@gondor.apana.org.au> > Cc: "David S. Miller" <davem@davemloft.net> > Cc: linux-crypto@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > > Signed-off-by: Jack Wang <jinpu.wang@ionos.com> > --- > drivers/crypto/ccree/cc_buffer_mgr.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/crypto/ccree/cc_buffer_mgr.c b/drivers/crypto/ccree/cc_buffer_mgr.c > index 6140e4927322..9efd88f871d1 100644 > --- a/drivers/crypto/ccree/cc_buffer_mgr.c > +++ b/drivers/crypto/ccree/cc_buffer_mgr.c > @@ -274,7 +274,7 @@ static int cc_map_sg(struct device *dev, struct scatterlist *sg, > } > > ret = dma_map_sg(dev, sg, *nents, direction); > - if (dma_mapping_error(dev, ret)) { > + if (!ret) { > *nents = 0; > dev_err(dev, "dma_map_sg() sg buffer failed %d\n", ret); > return -ENOMEM; > -- > 2.34.1 >
Good catch!
Thank you for the patch.
Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
Gilad
-- Gilad Ben-Yossef Chief Coffee Drinker
values of β will give rise to dom!
| |