Messages in this thread | | | From | Jinpu Wang <> | Date | Mon, 22 Aug 2022 07:15:53 +0200 | Subject | Re: [PATCH v1 17/19] mmc: meson-mx-sdhc: Fix error check for dma_map_sg |
| |
Hi Martin, On Sat, Aug 20, 2022 at 7:26 PM Martin Blumenstingl <martin.blumenstingl@googlemail.com> wrote: > > Hello Jack, > > first of all: thank you for this patch! welcome. > > On Fri, Aug 19, 2022 at 8:08 AM Jack Wang <jinpu.wang@ionos.com> wrote: > [...] > > @@ -388,7 +388,7 @@ static int meson_mx_sdhc_map_dma(struct mmc_host *mmc, struct mmc_request *mrq) > > > > dma_len = dma_map_sg(mmc_dev(mmc), data->sg, data->sg_len, > Does it also make sense to change the type of the dma_len variable > from (signed) int to "unsigned int" (a few lines above)? I double checked, it seems a good idea, I will do it in v2. > > > Best regards, > Martin Thx!
| |