lkml.org 
[lkml]   [2022]   [Aug]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v1 08/19] crypto: sahara: Fix error check for dma_map_sg
    Date
    dma_map_sg return 0 on error, it returns the number of
    DMA address segments mapped (this may be shorter
    than <nents> passed in if some elements of the scatter/gather
    list are physically or virtually adjacent and an IOMMU maps
    them with a single entry).

    Cc: Herbert Xu <herbert@gondor.apana.org.au>
    Cc: "David S. Miller" <davem@davemloft.net>
    Cc: linux-crypto@vger.kernel.org
    Cc: linux-kernel@vger.kernel.org

    Signed-off-by: Jack Wang <jinpu.wang@ionos.com>
    ---
    drivers/crypto/sahara.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/crypto/sahara.c b/drivers/crypto/sahara.c
    index 457084b344c1..bb71aac30e2c 100644
    --- a/drivers/crypto/sahara.c
    +++ b/drivers/crypto/sahara.c
    @@ -487,13 +487,13 @@ static int sahara_hw_descriptor_create(struct sahara_dev *dev)

    ret = dma_map_sg(dev->device, dev->in_sg, dev->nb_in_sg,
    DMA_TO_DEVICE);
    - if (ret != dev->nb_in_sg) {
    + if (!ret) {
    dev_err(dev->device, "couldn't map in sg\n");
    goto unmap_in;
    }
    ret = dma_map_sg(dev->device, dev->out_sg, dev->nb_out_sg,
    DMA_FROM_DEVICE);
    - if (ret != dev->nb_out_sg) {
    + if (!ret) {
    dev_err(dev->device, "couldn't map out sg\n");
    goto unmap_out;
    }
    --
    2.34.1
    \
     
     \ /
      Last update: 2022-08-19 08:09    [W:2.725 / U:1.052 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site