Messages in this thread | | | Date | Tue, 2 Aug 2022 13:32:53 +0300 | From | Vladimir Oltean <> | Subject | Re: [Patch RFC net-next 1/4] net: dsa: microchip: modify vlan_add function prototype |
| |
On Fri, Jul 29, 2022 at 08:47:30PM +0530, Arun Ramadoss wrote: > diff --git a/drivers/net/dsa/microchip/ksz8.h b/drivers/net/dsa/microchip/ksz8.h > index 42c50cc4d853..6529f2e2426a 100644 > --- a/drivers/net/dsa/microchip/ksz8.h > +++ b/drivers/net/dsa/microchip/ksz8.h > @@ -38,9 +38,8 @@ int ksz8_mdb_del(struct ksz_device *dev, int port, > const struct switchdev_obj_port_mdb *mdb, struct dsa_db db); > int ksz8_port_vlan_filtering(struct ksz_device *dev, int port, bool flag, > struct netlink_ext_ack *extack); > -int ksz8_port_vlan_add(struct ksz_device *dev, int port, > - const struct switchdev_obj_port_vlan *vlan, > - struct netlink_ext_ack *extack); > +int ksz8_port_vlan_add(struct ksz_device *dev, int port, u16 vlan_vid,
I don't see an impediment to naming "vlan_vid" just "vid".
> + u16 flags); > int ksz8_port_vlan_del(struct ksz_device *dev, int port, > const struct switchdev_obj_port_vlan *vlan);
Won't you convert vlan_del too?
| |