lkml.org 
[lkml]   [2022]   [Jul]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 01/10] platform/chrome: cros_kunit_util: add default value for `msg->result`
On Mon, Jul 18, 2022 at 06:35:42AM -0700, Guenter Roeck wrote:
> On Sun, Jul 17, 2022 at 10:10 PM Tzung-Bi Shih <tzungbi@kernel.org> wrote:
> > +int cros_kunit_ec_xfer_mock_default_result;
> > +EXPORT_SYMBOL_GPL(cros_kunit_ec_xfer_mock_default_result);
>
> Is this needed as a global variable and, if so, does it really have to
> be exported ?
>
> > int cros_kunit_ec_xfer_mock_default_ret;
> > EXPORT_SYMBOL_GPL(cros_kunit_ec_xfer_mock_default_ret);
>
> Same here, really, only I didn't notice before.

Global variables: I'm afraid yes. They should be accessible to test cases
(e.g. drivers/platform/chrome/cros_ec_proto_test.c).

Exported: I'm not sure if I fixed it in a proper way. They were added for
fixing https://lkml.org/lkml/2022/6/2/452. When CONFIG_CROS_KUNIT=m and
CONFIG_CROS_EC_PROTO_KUNIT_TEST=m, cros_ec_proto_test.c still needs to access
them (in cros_kunit_util.c).

\
 
 \ /
  Last update: 2022-07-19 06:01    [W:0.117 / U:1.276 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site