Messages in this thread | | | From | Guenter Roeck <> | Date | Mon, 18 Jul 2022 06:35:42 -0700 | Subject | Re: [PATCH v2 01/10] platform/chrome: cros_kunit_util: add default value for `msg->result` |
| |
On Sun, Jul 17, 2022 at 10:10 PM Tzung-Bi Shih <tzungbi@kernel.org> wrote: > > Add default value for `msg->result` so that it won't be garbage bytes > when the mock list is empty. > > Signed-off-by: Tzung-Bi Shih <tzungbi@kernel.org> > --- > No v1. New in the series. > > drivers/platform/chrome/cros_kunit_util.c | 7 ++++++- > drivers/platform/chrome/cros_kunit_util.h | 1 + > 2 files changed, 7 insertions(+), 1 deletion(-) > > diff --git a/drivers/platform/chrome/cros_kunit_util.c b/drivers/platform/chrome/cros_kunit_util.c > index e031777dea87..6810d558d462 100644 > --- a/drivers/platform/chrome/cros_kunit_util.c > +++ b/drivers/platform/chrome/cros_kunit_util.c > @@ -13,6 +13,8 @@ > #include "cros_ec.h" > #include "cros_kunit_util.h" > > +int cros_kunit_ec_xfer_mock_default_result; > +EXPORT_SYMBOL_GPL(cros_kunit_ec_xfer_mock_default_result);
Is this needed as a global variable and, if so, does it really have to be exported ?
> int cros_kunit_ec_xfer_mock_default_ret; > EXPORT_SYMBOL_GPL(cros_kunit_ec_xfer_mock_default_ret);
Same here, really, only I didn't notice before.
Thanks, Guenter
> > @@ -24,8 +26,10 @@ int cros_kunit_ec_xfer_mock(struct cros_ec_device *ec_dev, struct cros_ec_comman > struct ec_xfer_mock *mock; > > mock = list_first_entry_or_null(&cros_kunit_ec_xfer_mock_in, struct ec_xfer_mock, list); > - if (!mock) > + if (!mock) { > + msg->result = cros_kunit_ec_xfer_mock_default_result; > return cros_kunit_ec_xfer_mock_default_ret; > + } > > list_del(&mock->list); > > @@ -89,6 +93,7 @@ EXPORT_SYMBOL_GPL(cros_kunit_ec_xfer_mock_next); > > void cros_kunit_mock_reset(void) > { > + cros_kunit_ec_xfer_mock_default_result = 0; > cros_kunit_ec_xfer_mock_default_ret = 0; > INIT_LIST_HEAD(&cros_kunit_ec_xfer_mock_in); > INIT_LIST_HEAD(&cros_kunit_ec_xfer_mock_out); > diff --git a/drivers/platform/chrome/cros_kunit_util.h b/drivers/platform/chrome/cros_kunit_util.h > index 79c4525f873c..79c4f259f2bb 100644 > --- a/drivers/platform/chrome/cros_kunit_util.h > +++ b/drivers/platform/chrome/cros_kunit_util.h > @@ -23,6 +23,7 @@ struct ec_xfer_mock { > u32 o_data_len; > }; > > +extern int cros_kunit_ec_xfer_mock_default_result; > extern int cros_kunit_ec_xfer_mock_default_ret; > > int cros_kunit_ec_xfer_mock(struct cros_ec_device *ec_dev, struct cros_ec_command *msg); > -- > 2.37.0.170.g444d1eabd0-goog >
| |