Messages in this thread | | | Date | Wed, 20 Jul 2022 01:00:16 +0000 | From | Tzung-Bi Shih <> | Subject | Re: [PATCH v2 01/10] platform/chrome: cros_kunit_util: add default value for `msg->result` |
| |
On Tue, Jul 19, 2022 at 02:27:49PM -0700, Guenter Roeck wrote: > On Mon, Jul 18, 2022 at 9:00 PM Tzung-Bi Shih <tzungbi@kernel.org> wrote: > > > > On Mon, Jul 18, 2022 at 06:35:42AM -0700, Guenter Roeck wrote: > > > On Sun, Jul 17, 2022 at 10:10 PM Tzung-Bi Shih <tzungbi@kernel.org> wrote: > > > > +int cros_kunit_ec_xfer_mock_default_result; > > > > +EXPORT_SYMBOL_GPL(cros_kunit_ec_xfer_mock_default_result); > > > > > > Is this needed as a global variable and, if so, does it really have to > > > be exported ? > > > > > > > int cros_kunit_ec_xfer_mock_default_ret; > > > > EXPORT_SYMBOL_GPL(cros_kunit_ec_xfer_mock_default_ret); > > > > > > Same here, really, only I didn't notice before. > > > > Global variables: I'm afraid yes. They should be accessible to test cases > > (e.g. drivers/platform/chrome/cros_ec_proto_test.c). > > > > Hmm, I don't see where that is used. Either case, even if the > variables are supposed to be used from cros_ec_proto_test.o, I don't > see why cros_ec_proto_test.o and cros_kunit_util.o need to be separate > modules. Can you combine them into a single module ? That would avoid > the exports.
Ack. I realized these shouldn't be in current series. Will separate them into an indepedent series.
| |