Messages in this thread | | | Date | Tue, 19 Jul 2022 09:07:53 +0800 | From | Huang Rui <> | Subject | Re: [PATCH v4 13/13] cpufreq: CPPC: remove the acpi_disabled check |
| |
On Fri, Jul 15, 2022 at 06:04:32PM +0800, Yuan, Perry wrote: > "acpi_cpc_valid" function already includes the acpi_disabled check and we can > remove the duplicated check here > > Acked-by: Viresh Kumar <viresh.kumar@linaro.org> > Signed-off-by: Perry Yuan <Perry.Yuan@amd.com>
Patch 10, 12, and 13 should be one function update to move the acpi_disabled check into acpi_cpc_valid(), should we squeeze them as one patch?
Thanks, Ray
> --- > drivers/cpufreq/cppc_cpufreq.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/cpufreq/cppc_cpufreq.c b/drivers/cpufreq/cppc_cpufreq.c > index 24eaf0ec344d..9adb7612993e 100644 > --- a/drivers/cpufreq/cppc_cpufreq.c > +++ b/drivers/cpufreq/cppc_cpufreq.c > @@ -947,7 +947,7 @@ static int __init cppc_cpufreq_init(void) > { > int ret; > > - if ((acpi_disabled) || !acpi_cpc_valid()) > + if (!acpi_cpc_valid()) > return -ENODEV; > > cppc_check_hisi_workaround(); > -- > 2.32.0 >
| |