lkml.org 
[lkml]   [2022]   [Jul]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v4 10/13] cpufreq: amd-pstate: add ACPI disabled check in acpi_cpc_valid()
    Date
    Add acpi function check in case ACPI is not enabled, that will cause
    pstate driver failed to call cppc acpi to change perf or update epp
    value for shared memory solution processors.

    When CPPC or ACPI is invalid, warning log will be needed to tell
    user that AMD pstate driver failed to load and what is wrong.

    Signed-off-by: Perry Yuan <Perry.Yuan@amd.com>
    ---
    drivers/acpi/cppc_acpi.c | 3 +++
    drivers/cpufreq/amd-pstate.c | 2 +-
    2 files changed, 4 insertions(+), 1 deletion(-)

    diff --git a/drivers/acpi/cppc_acpi.c b/drivers/acpi/cppc_acpi.c
    index 6ff1901d7d43..17d67e3ededf 100644
    --- a/drivers/acpi/cppc_acpi.c
    +++ b/drivers/acpi/cppc_acpi.c
    @@ -424,6 +424,9 @@ bool acpi_cpc_valid(void)
    struct cpc_desc *cpc_ptr;
    int cpu;

    + if (acpi_disabled)
    + return false;
    +
    for_each_present_cpu(cpu) {
    cpc_ptr = per_cpu(cpc_desc_ptr, cpu);
    if (!cpc_ptr)
    diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
    index c29d36f56ab4..4f8600a36194 100644
    --- a/drivers/cpufreq/amd-pstate.c
    +++ b/drivers/cpufreq/amd-pstate.c
    @@ -685,7 +685,7 @@ static int __init amd_pstate_init(void)
    return -ENODEV;

    if (!acpi_cpc_valid()) {
    - pr_debug("the _CPC object is not present in SBIOS\n");
    + pr_warn_once("the _CPC object is not present in SBIOS or ACPI disabled\n");
    return -ENODEV;
    }

    --
    2.32.0
    \
     
     \ /
      Last update: 2022-07-15 12:07    [W:4.024 / U:0.076 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site