lkml.org 
[lkml]   [2022]   [Jun]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 00/12] Clang -Wformat warning fixes
On Thu,  9 Jun 2022 22:16:19 +0000 Bill Wendling <morbo@google.com> wrote:

> This patch set fixes some clang warnings when -Wformat is enabled.
>

tldr:

- printk(msg);
+ printk("%s", msg);

the only reason to make this change is where `msg' could contain a `%'.
Generally, it came from userspace. Otherwise these changes are a
useless consumer of runtime resources.

I think it would be better to quieten clang in some fashion.

\
 
 \ /
  Last update: 2022-06-10 00:27    [W:0.193 / U:0.284 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site