lkml.org 
[lkml]   [2022]   [Jun]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 00/12] Clang -Wformat warning fixes
    On Thu, Jun 9, 2022 at 4:03 PM Jan Engelhardt <jengelh@inai.de> wrote:
    > On Friday 2022-06-10 00:49, Bill Wendling wrote:
    > >On Thu, Jun 9, 2022 at 3:25 PM Andrew Morton <akpm@linux-foundation.org> wrote:
    > >> On Thu, 9 Jun 2022 22:16:19 +0000 Bill Wendling <morbo@google.com> wrote:
    > >>
    > >> > This patch set fixes some clang warnings when -Wformat is enabled.
    > >>
    > >> tldr:
    > >>
    > >> - printk(msg);
    > >> + printk("%s", msg);
    > >>
    > >> Otherwise these changes are a
    > >> useless consumer of runtime resources.
    > >
    > >Calling a "printf" style function is already insanely expensive.
    > >[...]
    > >The "printk" and similar functions all have the "__printf" attribute.
    > >I don't know of a modification to that attribute which can turn off
    > >this type of check.
    >
    > Perhaps you can split vprintk_store in the middle (after the call to
    > vsnprintf), and offer the second half as a function of its own (e.g.
    > "puts"). Then the tldr could be
    >
    > - printk(msg);
    > + puts(msg);

    That might be a nice compromise. Andrew, what do you think?

    -bw

    \
     
     \ /
      Last update: 2022-06-10 01:17    [W:2.873 / U:0.088 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site