lkml.org 
[lkml]   [2022]   [Jun]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
Subject[PATCH 06/12] PNP: use correct format characters
From
From: Bill Wendling <isanbard@gmail.com>

When compiling with -Wformat, clang emits the following warnings:

drivers/pnp/interface.c:273:22: error: format string is not a string literal (potentially insecure) [-Werror,-Wformat-security]
pnp_printf(buffer, pnp_resource_type_name(res));
^~~~~~~~~~~~~~~~~~~~~~~~~~~

Use a string literal for the format string.

Link: https://github.com/ClangBuiltLinux/linux/issues/378
Signed-off-by: Bill Wendling <isanbard@gmail.com>
---
drivers/pnp/interface.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pnp/interface.c b/drivers/pnp/interface.c
index 44efcdb87e6f..553221a0c89a 100644
--- a/drivers/pnp/interface.c
+++ b/drivers/pnp/interface.c
@@ -270,7 +270,7 @@ static ssize_t resources_show(struct device *dmdev,
list_for_each_entry(pnp_res, &dev->resources, list) {
res = &pnp_res->res;

- pnp_printf(buffer, pnp_resource_type_name(res));
+ pnp_printf(buffer, "%s", pnp_resource_type_name(res));

if (res->flags & IORESOURCE_DISABLED) {
pnp_printf(buffer, " disabled\n");
--
2.36.1.255.ge46751e96f-goog
\
 
 \ /
  Last update: 2022-06-10 00:21    [W:0.185 / U:0.396 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site