lkml.org 
[lkml]   [2022]   [Jun]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v1 net-next 3/5] ptp_ocp: drop duplicate NULL check in ptp_ocp_detach()
From
On 08.06.2022 13:03, Andy Shevchenko wrote:
> Since platform_device_unregister() is NULL-aware, we don't need to duplicate
> this check. Remove it and fold the rest of the code.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Acked-by: Vadim Fedorenko <vfedorenko@novek.ru>
> ---
> drivers/ptp/ptp_ocp.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/ptp/ptp_ocp.c b/drivers/ptp/ptp_ocp.c
> index 926add7be9a2..4e237f806085 100644
> --- a/drivers/ptp/ptp_ocp.c
> +++ b/drivers/ptp/ptp_ocp.c
> @@ -3701,10 +3701,8 @@ ptp_ocp_detach(struct ptp_ocp *bp)
> serial8250_unregister_port(bp->mac_port);
> if (bp->nmea_port != -1)
> serial8250_unregister_port(bp->nmea_port);
> - if (bp->spi_flash)
> - platform_device_unregister(bp->spi_flash);
> - if (bp->i2c_ctrl)
> - platform_device_unregister(bp->i2c_ctrl);
> + platform_device_unregister(bp->spi_flash);
> + platform_device_unregister(bp->i2c_ctrl);
> if (bp->i2c_clk)
> clk_hw_unregister_fixed_rate(bp->i2c_clk);
> if (bp->n_irqs)

\
 
 \ /
  Last update: 2022-06-08 23:43    [W:0.175 / U:0.148 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site