Messages in this thread | | | From | Andy Shevchenko <> | Date | Thu, 9 Jun 2022 12:43:30 +0200 | Subject | Re: [PATCH v1 net-next 4/5] ptp_ocp: do not call pci_set_drvdata(pdev, NULL) |
| |
On Thu, Jun 9, 2022 at 12:01 AM Vadim Fedorenko <vfedorenko@novek.ru> wrote: > > On 08.06.2022 13:03, Andy Shevchenko wrote: > > Cleaning up driver data is actually already handled by driver core, > > so there is no need to do it manually. > > I found a couple of places with exactly the same code in error path. > For example Marvell's OcteonX drivers in crypto and net subsystems. > Should we fix them too?
I believe there are even more, but feel free to fix them, they are not my POI.
...
> Overall looks good. > > Acked-by: Vadim Fedorenko <vfedorenko@novek.ru>
Thanks!
-- With Best Regards, Andy Shevchenko
| |