lkml.org 
[lkml]   [2022]   [Jun]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v1 net-next 4/5] ptp_ocp: do not call pci_set_drvdata(pdev, NULL)
From
On 08.06.2022 13:03, Andy Shevchenko wrote:
> Cleaning up driver data is actually already handled by driver core,
> so there is no need to do it manually.

I found a couple of places with exactly the same code in error path.
For example Marvell's OcteonX drivers in crypto and net subsystems.
Should we fix them too?

> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Overall looks good.

Acked-by: Vadim Fedorenko <vfedorenko@novek.ru>

> ---
> drivers/ptp/ptp_ocp.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/ptp/ptp_ocp.c b/drivers/ptp/ptp_ocp.c
> index 4e237f806085..857e35c68a04 100644
> --- a/drivers/ptp/ptp_ocp.c
> +++ b/drivers/ptp/ptp_ocp.c
> @@ -3769,7 +3769,6 @@ ptp_ocp_probe(struct pci_dev *pdev, const struct pci_device_id *id)
>
> out:
> ptp_ocp_detach(bp);
> - pci_set_drvdata(pdev, NULL);
> out_disable:
> pci_disable_device(pdev);
> out_free:
> @@ -3785,7 +3784,6 @@ ptp_ocp_remove(struct pci_dev *pdev)
>
> devlink_unregister(devlink);
> ptp_ocp_detach(bp);
> - pci_set_drvdata(pdev, NULL);
> pci_disable_device(pdev);
>
> devlink_free(devlink);

\
 
 \ /
  Last update: 2022-09-17 16:25    [W:0.265 / U:0.300 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site