Messages in this thread | | | From | Guenter Roeck <> | Date | Wed, 8 Jun 2022 09:15:56 -0700 | Subject | Re: [PATCH v3 13/23] platform/chrome: cros_ec: don't allocate `din` and `dout` in cros_ec_register() |
| |
On Wed, Jun 8, 2022 at 4:08 AM Tzung-Bi Shih <tzungbi@kernel.org> wrote: > > Don't allocate `din` and `dout` in cros_ec_register() as they will be > allocated soon in cros_ec_query_all(). > > Signed-off-by: Tzung-Bi Shih <tzungbi@kernel.org>
Reviewed-by: Guenter Roeck <groeck@chromium.org>
> --- > No change from v2. > > drivers/platform/chrome/cros_ec.c | 10 ++-------- > 1 file changed, 2 insertions(+), 8 deletions(-) > > diff --git a/drivers/platform/chrome/cros_ec.c b/drivers/platform/chrome/cros_ec.c > index e51a3f2176c7..29d3b544dafb 100644 > --- a/drivers/platform/chrome/cros_ec.c > +++ b/drivers/platform/chrome/cros_ec.c > @@ -188,14 +188,8 @@ int cros_ec_register(struct cros_ec_device *ec_dev) > ec_dev->max_passthru = 0; > ec_dev->ec = NULL; > ec_dev->pd = NULL; > - > - ec_dev->din = devm_kzalloc(dev, ec_dev->din_size, GFP_KERNEL); > - if (!ec_dev->din) > - return -ENOMEM; > - > - ec_dev->dout = devm_kzalloc(dev, ec_dev->dout_size, GFP_KERNEL); > - if (!ec_dev->dout) > - return -ENOMEM; > + ec_dev->din = NULL; > + ec_dev->dout = NULL; > > mutex_init(&ec_dev->lock); > > -- > 2.36.1.255.ge46751e96f-goog >
| |