lkml.org 
[lkml]   [2022]   [Jun]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v3 05/23] platform/chrome: cros_ec_proto: remove redundant NULL check
    Date
    send_command() already checks if `ec_dev->pkt_xfer` is NULL.  Remove the
    redundant check.

    Reviewed-by: Guenter Roeck <groeck@chromium.org>
    Signed-off-by: Tzung-Bi Shih <tzungbi@kernel.org>
    ---
    No change from v2.

    Changes from v1:
    - Add R-b tag.

    drivers/platform/chrome/cros_ec_proto.c | 3 ---
    1 file changed, 3 deletions(-)

    diff --git a/drivers/platform/chrome/cros_ec_proto.c b/drivers/platform/chrome/cros_ec_proto.c
    index 629dce3e6ab3..1b851dcd20c9 100644
    --- a/drivers/platform/chrome/cros_ec_proto.c
    +++ b/drivers/platform/chrome/cros_ec_proto.c
    @@ -281,9 +281,6 @@ static int cros_ec_host_command_proto_query(struct cros_ec_device *ec_dev,
    */
    int ret;

    - if (!ec_dev->pkt_xfer)
    - return -EPROTONOSUPPORT;
    -
    memset(msg, 0, sizeof(*msg));
    msg->command = EC_CMD_PASSTHRU_OFFSET(devidx) | EC_CMD_GET_PROTOCOL_INFO;
    msg->insize = sizeof(struct ec_response_get_protocol_info);
    --
    2.36.1.255.ge46751e96f-goog
    \
     
     \ /
      Last update: 2022-06-08 13:09    [W:4.681 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site