lkml.org 
[lkml]   [2022]   [Jun]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v3 21/23] platform/chrome: cros_ec_proto: return 0 on getting wake mask success
    Date
    cros_ec_get_host_event_wake_mask() used to return value from
    send_command() which is number of bytes for input payload on success
    (i.e. sizeof(struct ec_response_host_event_mask)).

    However, the callers don't need to know how many bytes are available.

    Don't return number of available bytes. Instead, return 0 on success;
    otherwise, negative integers on error.

    Signed-off-by: Tzung-Bi Shih <tzungbi@kernel.org>
    ---
    Changes from v2:
    - Separate Kunit test to another patch.

    Changes from v1:
    - Return 0 on success; otherwise, negative intergers.

    drivers/platform/chrome/cros_ec_proto.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    diff --git a/drivers/platform/chrome/cros_ec_proto.c b/drivers/platform/chrome/cros_ec_proto.c
    index 9e95f9e4b2f8..68a411e84744 100644
    --- a/drivers/platform/chrome/cros_ec_proto.c
    +++ b/drivers/platform/chrome/cros_ec_proto.c
    @@ -236,7 +236,7 @@ EXPORT_SYMBOL(cros_ec_check_result);
    *
    * @ec_dev: EC device to call
    * @msg: message structure to use
    - * @mask: result when function returns >=0.
    + * @mask: result when function returns 0.
    *
    * LOCKING:
    * the caller has ec_dev->lock mutex, or the caller knows there is
    @@ -266,6 +266,7 @@ static int cros_ec_get_host_event_wake_mask(struct cros_ec_device *ec_dev, uint3
    if (ret > 0) {
    r = (struct ec_response_host_event_mask *)msg->data;
    *mask = r->mask;
    + ret = 0;
    }

    exit:
    --
    2.36.1.255.ge46751e96f-goog
    \
     
     \ /
      Last update: 2022-06-08 13:14    [W:4.084 / U:0.156 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site