| Date | Wed, 22 Jun 2022 20:04:54 +0300 | From | Andy Shevchenko <> | Subject | Re: [PATCH 1/8] serial: core: only get RS485 termination gpio if supported |
| |
On Wed, Jun 22, 2022 at 05:46:52PM +0200, Lino Sanfilippo wrote: > From: Lino Sanfilippo <l.sanfilippo@kunbus.com> > > In uart_get_rs485_mode() only try to get a termination GPIO if RS485 bus > termination is supported by the driver.
I'm not sure I got the usefulness of this change. We request GPIO line as optional, so if one is defined it in the DT/ACPI, then they probably want to (opportunistically) have it.
The certain driver may or may not utilize this GPIO.
With your change it's possible to have a DTS where GPIO line defined in a broken way and user won't ever know about it, if they are using platforms without termination support.
-- With Best Regards, Andy Shevchenko
|