lkml.org 
[lkml]   [2022]   [Jun]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 7/8] serial: ar933x: Remove redundant assignment in rs485_config
On Wed, 22 Jun 2022, Lino Sanfilippo wrote:

> From: Lino Sanfilippo <l.sanfilippo@kunbus.com>
>
> In uart_set_rs485_config() the serial core already assigns the passed
> serial_rs485 struct to the uart port.
>
> So remove the assignment in the drivers rs485_config() function to avoid
> redundancy.
>
> Signed-off-by: Lino Sanfilippo <l.sanfilippo@kunbus.com>
> ---
> drivers/tty/serial/ar933x_uart.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/tty/serial/ar933x_uart.c b/drivers/tty/serial/ar933x_uart.c
> index ab2c5b2a1ce8..857e010d01dc 100644
> --- a/drivers/tty/serial/ar933x_uart.c
> +++ b/drivers/tty/serial/ar933x_uart.c
> @@ -591,7 +591,6 @@ static int ar933x_config_rs485(struct uart_port *port,
> dev_err(port->dev, "RS485 needs rts-gpio\n");
> return 1;
> }
> - port->rs485 = *rs485conf;
> return 0;
> }

Hmm, I realize that for some reason I missed cleaning up this particular
driver after introducing the serial_rs485 sanitization. It shouldn't need
that preceeding if block either because ar933x_no_rs485 gets applied if
there's no rts_gpiod so the core clears SER_RS485_ENABLED.


--
i.

\
 
 \ /
  Last update: 2022-06-25 12:15    [W:0.248 / U:0.228 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site