lkml.org 
[lkml]   [2022]   [Jun]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v3 3/5] PCI: axis: Add ARTPEC-8 PCIe controller driver
From
Date
On 20/06/2022 17:35, Krzysztof Kozlowski wrote:
> On 14/06/2022 03:30, Wangseok Lee wrote:
>> Add support Axis, ARTPEC-8 SoC.
>> ARTPEC-8 is the SoC platform of Axis Communications.
>> 
>
> (...)
>
>> +
>> +enum artpec8_pcie_isolation {
>> +        PCIE_CLEAR_ISOLATION = 0,
>> +        PCIE_SET_ISOLATION = 1
>> +};
>> +
>> +enum artpec8_pcie_reg_bit {
>> +        PCIE_REG_BIT_LOW = 0,
>> +        PCIE_REG_BIT_HIGH = 1
>> +};
>
> Remove this enum. This is redefinition of true/false or 1/0.
>
> Best regards,
> Krzysztof

ok, i will change the above enum types to boolean.

Thank you for kindness reivew.

Best regards,
Wangseok Lee

\
 
 \ /
  Last update: 2022-06-21 09:57    [W:0.213 / U:0.444 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site