Messages in this thread Patch in this message | | | From | Kees Cook <> | Subject | [PATCH] lib: overflow: Always build 64-bit test cases | Date | Wed, 11 May 2022 10:45:31 -0700 |
| |
There shouldn't be a reason to not build the 64-bit test cases on 32-bit systems; the types exist there too. Remove the #ifdefs.
Reported-by: kernel test robot <lkp@intel.com> Link: https://lore.kernel.org/lkml/202205110324.7GrtxG8u-lkp@intel.com Fixes: 455a35a6cdb6 ("lib: add runtime test of check_*_overflow functions") Cc: Rasmus Villemoes <linux@rasmusvillemoes.dk> Cc: Vitor Massaru Iha <vitor@massaru.org> Cc: "Gustavo A. R. Silva" <gustavoars@kernel.org> Cc: Daniel Latypov <dlatypov@google.com> Signed-off-by: Kees Cook <keescook@chromium.org> --- lib/overflow_kunit.c | 4 ---- 1 file changed, 4 deletions(-)
diff --git a/lib/overflow_kunit.c b/lib/overflow_kunit.c index 475f0c064bf6..ac37bb543476 100644 --- a/lib/overflow_kunit.c +++ b/lib/overflow_kunit.c @@ -255,10 +255,8 @@ DEFINE_TEST_FUNC(u16, "%d"); DEFINE_TEST_FUNC(s16, "%d"); DEFINE_TEST_FUNC(u32, "%u"); DEFINE_TEST_FUNC(s32, "%d"); -#if BITS_PER_LONG == 64 DEFINE_TEST_FUNC(u64, "%llu"); DEFINE_TEST_FUNC(s64, "%lld"); -#endif static void overflow_shift_test(struct kunit *test) { @@ -650,10 +648,8 @@ static struct kunit_case overflow_test_cases[] = { KUNIT_CASE(s16_overflow_test), KUNIT_CASE(u32_overflow_test), KUNIT_CASE(s32_overflow_test), -#if BITS_PER_LONG == 64 KUNIT_CASE(u64_overflow_test), KUNIT_CASE(s64_overflow_test), -#endif KUNIT_CASE(overflow_shift_test), KUNIT_CASE(overflow_allocation_test), KUNIT_CASE(overflow_size_helpers_test), -- 2.32.0
| |