Messages in this thread | | | From | Daniel Latypov <> | Date | Wed, 11 May 2022 11:27:26 -0700 | Subject | Re: [PATCH] lib: overflow: Always build 64-bit test cases |
| |
On Wed, May 11, 2022 at 10:45 AM Kees Cook <keescook@chromium.org> wrote: > > There shouldn't be a reason to not build the 64-bit test cases on 32-bit > systems; the types exist there too. Remove the #ifdefs. > > Reported-by: kernel test robot <lkp@intel.com> > Link: https://lore.kernel.org/lkml/202205110324.7GrtxG8u-lkp@intel.com > Fixes: 455a35a6cdb6 ("lib: add runtime test of check_*_overflow functions") > Cc: Rasmus Villemoes <linux@rasmusvillemoes.dk> > Cc: Vitor Massaru Iha <vitor@massaru.org> > Cc: "Gustavo A. R. Silva" <gustavoars@kernel.org> > Cc: Daniel Latypov <dlatypov@google.com> > Signed-off-by: Kees Cook <keescook@chromium.org>
Tested-by: Daniel Latypov <dlatypov@google.com>
Makes sense and looks good to me, I was able to run it via $ ./tools/testing/kunit/kunit.py run --arch=i386 --build_dir=kunit_i386/ overflow
Raw output was: # u64_overflow_test: 17 u64 arithmetic tests finished ok 7 - u64_overflow_test # s64_overflow_test: 21 s64 arithmetic tests finished ok 8 - s64_overflow_test
| |