Messages in this thread | | | Date | Thu, 7 Apr 2022 20:52:34 +0200 | Subject | Re: [PATCH 05/11] dt-bindings: spi: dw: Add Pensando Elba SoC SPI Controller bindings | From | Krzysztof Kozlowski <> |
| |
On 07/04/2022 01:36, Brad Larson wrote: > The Pensando Elba SoC has integrated the DW APB SPI Controller > and requires the property pensando,syscon-spics for access > to the spics control register. > > Signed-off-by: Brad Larson <brad@pensando.io> > --- > Change from V3: > - Add required property pensando,syscon-spics to go with > pensando,elba-spi
Thank you for your patch. There is something to discuss/improve.
> .../bindings/spi/snps,dw-apb-ssi.yaml | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml b/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml > index d7e08b03e204..41c3bbf5a55c 100644 > --- a/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml > +++ b/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml > @@ -37,6 +37,21 @@ allOf: > else: > required: > - interrupts > + - if: > + properties: > + compatible: > + contains: > + enum: > + - pensando,elba-spi > + then: > + properties: > + pensando,syscon-spics: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: > + Phandle to the system control device node which provides access to > + the spics control register
It looks you only need to poke one register from spics, so it could be something like:
items: - items: - description: Phandle to the system control device node - description: spics control register offset
Best regards, Krzysztof
| |