Messages in this thread | | | From | Brad Larson <> | Date | Wed, 25 May 2022 17:27:32 -0700 | Subject | Re: [PATCH 05/11] dt-bindings: spi: dw: Add Pensando Elba SoC SPI Controller bindings |
| |
Hi Krzysztof,
On Thu, Apr 7, 2022 at 11:52 AM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 07/04/2022 01:36, Brad Larson wrote: > > --- a/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml > > +++ b/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml > > @@ -37,6 +37,21 @@ allOf: > > else: > > required: > > - interrupts > > + - if: > > + properties: > > + compatible: > > + contains: > > + enum: > > + - pensando,elba-spi > > + then: > > + properties: > > + pensando,syscon-spics: > > + $ref: /schemas/types.yaml#/definitions/phandle > > + description: > > + Phandle to the system control device node which provides access to > > + the spics control register > > It looks you only need to poke one register from spics, so it could be > something like: > > items: > - items: > - description: Phandle to the system control device node > - description: spics control register offset
This looks better, I'll change to this approach for updated patchset.
Regards, Brad
| |