lkml.org 
[lkml]   [2022]   [May]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 05/11] dt-bindings: spi: dw: Add Pensando Elba SoC SPI Controller bindings
Hi Krzysztof,

On Thu, Apr 7, 2022 at 11:52 AM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 07/04/2022 01:36, Brad Larson wrote:
> > --- a/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml
> > +++ b/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml
> > @@ -37,6 +37,21 @@ allOf:
> > else:
> > required:
> > - interrupts
> > + - if:
> > + properties:
> > + compatible:
> > + contains:
> > + enum:
> > + - pensando,elba-spi
> > + then:
> > + properties:
> > + pensando,syscon-spics:
> > + $ref: /schemas/types.yaml#/definitions/phandle
> > + description:
> > + Phandle to the system control device node which provides access to
> > + the spics control register
>
> It looks you only need to poke one register from spics, so it could be
> something like:
>
> items:
> - items:
> - description: Phandle to the system control device node
> - description: spics control register offset

This looks better, I'll change to this approach for updated patchset.

Regards,
Brad

\
 
 \ /
  Last update: 2022-05-26 02:29    [W:0.065 / U:0.144 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site