Messages in this thread | | | From | Brad Larson <> | Date | Wed, 25 May 2022 08:49:25 -0700 | Subject | Re: [PATCH 03/11] dt-bindings: mmc: Add Pensando Elba SoC binding |
| |
Hi Krzysztof,
On Thu, Apr 7, 2022 at 11:57 AM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 07/04/2022 01:36, Brad Larson wrote: > > > > --- a/Documentation/devicetree/bindings/mmc/cdns,sdhci.yaml > > +++ b/Documentation/devicetree/bindings/mmc/cdns,sdhci.yaml > > @@ -19,10 +19,12 @@ properties: > > - enum: > > - microchip,mpfs-sd4hc > > - socionext,uniphier-sd4hc > > + - pensando,elba-sd4hc > > Put your entry in alphabetical order.
Yes, will order alphabetical.
> > - const: cdns,sd4hc > > > > reg: > > - maxItems: 1 > > + minItems: 1 > > + maxItems: 2 > > This needs allOf:if:then: which sets constraint on number of items per > different compatible. > > > > > interrupts: > > maxItems: 1
Thanks for the recommendation. Changing to this approach as the second item is only for Elba SoC.
Regards, Brad
| |