Messages in this thread Patch in this message | | | From | Shubhrajyoti Datta <> | Subject | [PATCH 4/7] tty: xilinx_uartps: Check clk_enable return value | Date | Fri, 29 Apr 2022 13:44:19 +0530 |
| |
Check for the clock enable return value.
Addresses-Coverity: Event check_return. Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com> --- drivers/tty/serial/xilinx_uartps.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c index 868f4e587263..bf0415f0a194 100644 --- a/drivers/tty/serial/xilinx_uartps.c +++ b/drivers/tty/serial/xilinx_uartps.c @@ -1347,12 +1347,18 @@ static int cdns_uart_resume(struct device *device) unsigned long flags; u32 ctrl_reg; int may_wake; + int ret; may_wake = device_may_wakeup(device); if (console_suspend_enabled && uart_console(port) && !may_wake) { - clk_enable(cdns_uart->pclk); - clk_enable(cdns_uart->uartclk); + ret = clk_enable(cdns_uart->pclk); + if (ret) + return ret; + + ret = clk_enable(cdns_uart->uartclk); + if (ret) + return ret; spin_lock_irqsave(&port->lock, flags); -- 2.25.1
| |