lkml.org 
[lkml]   [2022]   [May]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH 0/7] tty: xilinx_uartps: fixes and improvements
Date
Hi Greg,

Thanks for the review.

> -----Original Message-----
> From: Greg KH <gregkh@linuxfoundation.org>
> Sent: Friday, May 6, 2022 2:19 AM
> To: Shubhrajyoti Datta <shubhraj@xilinx.com>
> Cc: linux-serial@vger.kernel.org; Michal Simek <michals@xilinx.com>;
> jirislaby@kernel.org; git <git@xilinx.com>; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH 0/7] tty: xilinx_uartps: fixes and improvements
>
> On Fri, Apr 29, 2022 at 01:44:15PM +0530, Shubhrajyoti Datta wrote:
> > Many of the stuff is reported by static analysis changes are
> >
> > - Update the copyright text
> > - Check the return valuesof runtime and clock enable calls
> > - Check the ignore_status in the isr
> > - Prevent writing to the fifo when controller is disabled.
> >
> > Michal Simek (1):
> > xilinx: Update copyright text to correct format
> >
> > Shubhrajyoti Datta (6):
> > tty: xilinx_uartps: Check the clk_enable return value
> > tty: xilinx_uartps: Add check for runtime_get_sync calls
> > tty: xilinx_uartps: Check clk_enable return type
> > tty: xilinx_uartps: Make the timeout unsigned
> > serial: uartps: Fix the ignore_status
> > serial: uartps: Prevent writes when the controller is disabled
>
> Nit, why is the subject line prefix not unified here? Shouldn't they all be "tty:
> xilinx_uartps:" like 4 of them are?
>
> Can you fix up and resend?

I will fix up and resend in v2
>
> thanks,
>
> greg k-h

\
 
 \ /
  Last update: 2022-05-10 13:55    [W:0.191 / U:0.228 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site