Messages in this thread | | | Date | Sun, 27 Mar 2022 21:26:20 +0200 | Subject | Re: [PATCH 1/5] dt-bindings: mmc: imx-esdhc: Update compatible fallbacks | From | Krzysztof Kozlowski <> |
| |
On 27/03/2022 14:38, Adam Ford wrote: > The SDHC controller in the imx8mn and imx8mp have the same controller > as the imx8mm which is slightly different than that of the imx7d. > Using the fallback of the imx8mm enables the controllers to support > HS400-ES which is not available on the imx7d. After discussion with NXP, > it turns out that the imx8qm should fall back to the imx8qxp, because > those have some additional flags not present in the imx8mm. > > Suggested-by: haibo.chen@nxp.com > Signed-off-by: Adam Ford <aford173@gmail.com> > --- > V2: Added suggested-by note and imx8qxp updates. > --- > .../devicetree/bindings/mmc/fsl-imx-esdhc.yaml | 16 +++++++++------- > 1 file changed, 9 insertions(+), 7 deletions(-) >
YAML and logic looks good, although I did not check the actual hardware properties. Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Best regards, Krzysztof
| |