| From | <> | Subject | Re: [PATCH v1 11/14] mtd: spi-nor: spansion: slightly rework control flow in late_init() | Date | Thu, 10 Feb 2022 03:26:58 +0000 |
| |
On 2/2/22 16:58, Michael Walle wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > Increase readability of the code. Instead of returning early if the > flash size is smaller or equal than 16MiB and then do the fixups for > larger flashes, do it within the condition. >
mm, no, I'm not sure this improves readability, I see the two equivalent. The original version has the benefit of no indentation. Pratyush?
> Signed-off-by: Michael Walle <michael@walle.cc> > --- > drivers/mtd/spi-nor/spansion.c | 13 ++++++------- > 1 file changed, 6 insertions(+), 7 deletions(-) > > diff --git a/drivers/mtd/spi-nor/spansion.c b/drivers/mtd/spi-nor/spansion.c > index 534196b1d3e7..dedc2de90cb8 100644 > --- a/drivers/mtd/spi-nor/spansion.c > +++ b/drivers/mtd/spi-nor/spansion.c > @@ -296,13 +296,12 @@ static const struct flash_info spansion_parts[] = { > > static void spansion_late_init(struct spi_nor *nor) > { > - if (nor->params->size <= SZ_16M) > - return; > - > - nor->flags |= SNOR_F_4B_OPCODES; > - /* No small sector erase for 4-byte command set */ > - nor->erase_opcode = SPINOR_OP_SE; > - nor->mtd.erasesize = nor->info->sector_size; > + if (nor->params->size > SZ_16M) { > + nor->flags |= SNOR_F_4B_OPCODES; > + /* No small sector erase for 4-byte command set */ > + nor->erase_opcode = SPINOR_OP_SE; > + nor->mtd.erasesize = nor->info->sector_size; > + } > } > > static const struct spi_nor_fixups spansion_fixups = { > -- > 2.30.2 >
|