Messages in this thread | | | Date | Tue, 15 Feb 2022 00:29:49 +0530 | From | Pratyush Yadav <> | Subject | Re: [PATCH v1 11/14] mtd: spi-nor: spansion: slightly rework control flow in late_init() |
| |
On 10/02/22 03:26AM, Tudor.Ambarus@microchip.com wrote: > On 2/2/22 16:58, Michael Walle wrote: > > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > > > Increase readability of the code. Instead of returning early if the > > flash size is smaller or equal than 16MiB and then do the fixups for > > larger flashes, do it within the condition. > > > > mm, no, I'm not sure this improves readability, I see the two equivalent. > The original version has the benefit of no indentation. Pratyush?
I am fine with both to be honest. But Michael's reasoning does make some sense to me. So,
Reviewed-by: Pratyush Yadav <p.yadav@ti.com>
-- Regards, Pratyush Yadav Texas Instruments Inc.
| |