Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Mon, 7 Feb 2022 14:51:17 +0100 | Subject | Re: [PATCH 01/23] MM: create new mm/swap.h header file. |
| |
Hi Neil,
On Mon, Jan 24, 2022 at 5:26 PM NeilBrown <neilb@suse.de> wrote: > Many functions declared in include/linux/swap.h are only used within mm/ > > Create a new "mm/swap.h" and move some of these declarations there. > Remove the redundant 'extern' from the function declarations. > > Reviewed-by: Christoph Hellwig <hch@lst.de> > Signed-off-by: NeilBrown <neilb@suse.de>
Thanks for your patch!
mm/huge_memory.c: In function ‘__split_huge_page’: mm/huge_memory.c:2423:16: error: implicit declaration of function ‘swap_address_space’; did you mean ‘exit_swap_address_space’? [-Werror=implicit-function-declaration] 2423 | swap_cache = swap_address_space(entry); | ^~~~~~~~~~~~~~~~~~ | exit_swap_address_space
mm/huge_memory.c needs to #include "swap.h", too.
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |