> +extern int nfs_swap_rw(struct kiocb *, struct iov_iter *);Might be worth to drop the pointless extern while you're at it.Otherwise looks good:Reviewed-by: Christoph Hellwig <hch@lst.de>