lkml.org 
[lkml]   [2022]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 07/23] MM: perform async writes to SWP_FS_OPS swap-space using ->swap_rw
On Mon, Jan 24, 2022 at 02:48:32PM +1100, NeilBrown wrote:
>
> +static void sio_write_complete(struct kiocb *iocb, long ret)
> +{
> + struct swap_iocb *sio = container_of(iocb, struct swap_iocb, iocb);
> + struct page *page = sio->bvec.bv_page;
> +
> + if (ret != 0 && ret != PAGE_SIZE) {

ret == 0 isn't really a success case for ki_complete, it is something
that should never happen at all.

Otherwise looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>

\
 
 \ /
  Last update: 2022-01-24 09:50    [W:0.257 / U:0.592 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site