Messages in this thread Patch in this message | | | From | Jakob Koschel <> | Subject | [RFC PATCH 08/13] net: dsa: future proof usage of list iterator after the loop | Date | Thu, 17 Feb 2022 19:48:24 +0100 |
| |
With the speculative safe version of the list iterator p will be NULL if the terminating condition was hit and needs to be reset to p derived from the head, before using p->list.
Signed-off-by: Jakob Koschel <jakobkoschel@gmail.com> --- drivers/net/dsa/sja1105/sja1105_vl.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/drivers/net/dsa/sja1105/sja1105_vl.c b/drivers/net/dsa/sja1105/sja1105_vl.c index f5dca6a9b0f9..a4f2b95b09c4 100644 --- a/drivers/net/dsa/sja1105/sja1105_vl.c +++ b/drivers/net/dsa/sja1105/sja1105_vl.c @@ -40,6 +40,8 @@ static int sja1105_insert_gate_entry(struct sja1105_gating_config *gating_cfg, if (e->interval < p->interval) break; } + if (!p) + p = list_entry(p, &gating_cfg->entries, list); list_add(&e->list, p->list.prev); } -- 2.25.1
| |