Messages in this thread | | | Date | Fri, 18 Feb 2022 11:12:16 -0400 | From | Jason Gunthorpe <> | Subject | Re: [RFC PATCH 04/13] vfio/mdev: remove the usage of the list iterator after the loop |
| |
On Thu, Feb 17, 2022 at 07:48:20PM +0100, Jakob Koschel wrote: > It is unsafe to assume that tmp != mdev can only evaluate to false > if the break within the list iterator is hit. > > When the break is not hit, tmp is set to an address derived from the > head element. If mdev would match with that value of tmp it would allow > continuing beyond the safety check even if mdev was never found within > the list
I think due to other construction this is not actually possible, but I guess it is technically correct
This seems like just a straight up style fix with nothing to do with speculative execution though. Why not just send it as a proper patch?
Jason
| |