Messages in this thread | | | From | Rob Herring <> | Subject | Re: [RFC PATCH v2 3/3] dt-bindings: usb: snps,dwc3: add generic-xhci as child | Date | Fri, 30 Dec 2022 10:34:28 -0600 |
| |
On Thu, 29 Dec 2022 18:57:46 +0900, Daehwan Jung wrote: > Currently, dwc3 invokes just xhci platform driver(generic-xhci) without > DT schema even though xhci works as child of dwc3. It makes sense to add > xhci as child of dwc3 with DT schema. It also supports to use another > compatible in xhci platform driver. > > Signed-off-by: Daehwan Jung <dh10.jung@samsung.com> > --- > .../devicetree/bindings/usb/snps,dwc3.yaml | 29 +++++++++++++++++++ > 1 file changed, 29 insertions(+) >
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/usb/snps,dwc3.example.dtb: usb@4a200000: #size-cells:0:0: 0 was expected From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/1672307866-25839-4-git-send-email-dh10.jung@samsung.com
The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
| |