Messages in this thread | | | Date | Thu, 29 Dec 2022 11:19:09 +0100 | Subject | Re: [RFC PATCH v2 2/3] dt-bindings: usb: generic-xhci: add Samsung Exynos compatible | From | Krzysztof Kozlowski <> |
| |
On 29/12/2022 10:57, Daehwan Jung wrote: > Add compatible for Samsung Exynos SOCs
Missing full stop. Please explain here in details the hardware. Otherwise it looks it is not for any hardware and patch should be dropped.
Also, missing DTS. I am going to keep NAK-ing this till you provide the user.
NAK.
> > Signed-off-by: Daehwan Jung <dh10.jung@samsung.com> > --- > Documentation/devicetree/bindings/usb/generic-xhci.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/usb/generic-xhci.yaml b/Documentation/devicetree/bindings/usb/generic-xhci.yaml > index db841589fc33..f54aff477637 100644 > --- a/Documentation/devicetree/bindings/usb/generic-xhci.yaml > +++ b/Documentation/devicetree/bindings/usb/generic-xhci.yaml > @@ -29,6 +29,8 @@ properties: > enum: > - brcm,xhci-brcm-v2 > - brcm,bcm7445-xhci > + - description: Samsung Exynos SoCs with xHCI > + const: samsung,exynos-xhci
Missing fallback.
> - description: Generic xHCI device> const: xhci-platform > deprecated: true
Best regards, Krzysztof
| |