Messages in this thread | | | Date | Mon, 2 Jan 2023 14:30:37 +0900 | From | Jung Daehwan <> | Subject | Re: [RFC PATCH v2 2/3] dt-bindings: usb: generic-xhci: add Samsung Exynos compatible |
| |
On Thu, Dec 29, 2022 at 11:19:09AM +0100, Krzysztof Kozlowski wrote: > On 29/12/2022 10:57, Daehwan Jung wrote: > > Add compatible for Samsung Exynos SOCs > > Missing full stop. Please explain here in details the hardware. > Otherwise it looks it is not for any hardware and patch should be dropped. >
I got it. This patch may be for new feature of generic xhci not for exynos. I will add hardware description on next submission.
> Also, missing DTS. I am going to keep NAK-ing this till you provide the > user. > > NAK. >
I've added a example and checked bindings following below guides.
https://docs.kernel.org/devicetree/bindings/submitting-patches.html https://docs.kernel.org/devicetree/bindings/writing-schema.html
I have no idea that I have to also submit DTS. I will submit it on next submission.
> > > > Signed-off-by: Daehwan Jung <dh10.jung@samsung.com> > > --- > > Documentation/devicetree/bindings/usb/generic-xhci.yaml | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/usb/generic-xhci.yaml b/Documentation/devicetree/bindings/usb/generic-xhci.yaml > > index db841589fc33..f54aff477637 100644 > > --- a/Documentation/devicetree/bindings/usb/generic-xhci.yaml > > +++ b/Documentation/devicetree/bindings/usb/generic-xhci.yaml > > @@ -29,6 +29,8 @@ properties: > > enum: > > - brcm,xhci-brcm-v2 > > - brcm,bcm7445-xhci > > + - description: Samsung Exynos SoCs with xHCI > > + const: samsung,exynos-xhci > > Missing fallback.
Modifying it like below is OK?
decription: Samsung Exynos SoCs with xHCI items: - const: samsung,exynos-xhci - const: generic-xhci
Best Regards, Jung Daehwan
> > > - description: Generic xHCI device> const: xhci-platform > > deprecated: true > > Best regards, > Krzysztof > >
| |