lkml.org 
[lkml]   [2022]   [Dec]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH v3 1/2] dt-bindings: pinctrl: add schema for NXP S32 SoCs
Date
Hi Chester,

> +patternProperties:
> + '-pins$':

Sorry, I missed this in the previous versions. Could you change it to '_pins' (underscore)? In our .dts files we use underscore in the names for pinctrl configuration nodes e.g. i2c4_pins, usbotg_pins.

> + patternProperties:
> + '-grp[0-9]$':

The same comment also applies here.

> + llce-can0-pins {
> + llce-can0-grp0 {

This should also change to something like:
llce_can0_pins {
llce_can0_grp0 {
...
}
}

Otherwise, this and PATCH 2/2 look good to me.

Best regards,
Andrei

\
 
 \ /
  Last update: 2023-03-26 23:16    [W:0.135 / U:0.576 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site