Messages in this thread | | | Date | Wed, 21 Dec 2022 21:52:28 +0800 | From | Chester Lin <> | Subject | Re: [PATCH v3 1/2] dt-bindings: pinctrl: add schema for NXP S32 SoCs |
| |
Hi Krzysztof and Andrei,
Thanks for reviewing this patch!
On Wed, Dec 21, 2022 at 01:30:12PM +0100, Krzysztof Kozlowski wrote: > On 21/12/2022 13:28, Andrei Stefanescu wrote: > > Hi Chester, > > > >> +patternProperties: > >> + '-pins$': > > > > Sorry, I missed this in the previous versions. Could you change it to '_pins' (underscore)? In our .dts files we use underscore in the names for pinctrl configuration nodes e.g. i2c4_pins, usbotg_pins. > > You cannot have underscores as node names, so what do you mean here? You
Krzysztof is right, and Rob also reminded me in his comments in v1:
https://lore.kernel.org/linux-arm-kernel/20221102154903.GA3726664-robh@kernel.org/
Regards, Chester
> need to fix your DTS not introduce bad practices to mainline kernel. > > Best regards, > Krzysztof >
| |