lkml.org 
[lkml]   [2022]   [Dec]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH v1 1/2] iio: adc: ti-adc128s052: Use get_unaligned_beXX()
Date
This makes the driver code slightly easier to read.
While at it, use GENMASK() as well.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/iio/adc/ti-adc128s052.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/drivers/iio/adc/ti-adc128s052.c b/drivers/iio/adc/ti-adc128s052.c
index fc09ee6bb174..7c4e8025861c 100644
--- a/drivers/iio/adc/ti-adc128s052.c
+++ b/drivers/iio/adc/ti-adc128s052.c
@@ -9,6 +9,7 @@
* https://www.ti.com/lit/ds/symlink/adc124s021.pdf
*/

+#include <linux/bits.h>
#include <linux/err.h>
#include <linux/spi/spi.h>
#include <linux/module.h>
@@ -17,6 +18,8 @@
#include <linux/property.h>
#include <linux/regulator/consumer.h>

+#include <asm/unaligned.h>
+
struct adc128_configuration {
const struct iio_chan_spec *channels;
u8 num_channels;
@@ -33,6 +36,7 @@ struct adc128 {

static int adc128_adc_conversion(struct adc128 *adc, u8 channel)
{
+ u16 value;
int ret;

mutex_lock(&adc->lock);
@@ -53,7 +57,8 @@ static int adc128_adc_conversion(struct adc128 *adc, u8 channel)
if (ret < 0)
return ret;

- return ((adc->buffer[0] << 8 | adc->buffer[1]) & 0xFFF);
+ value = get_unaligned_be16(&adc->buffer);
+ return value & GENMASK(11, 0);
}

static int adc128_read_raw(struct iio_dev *indio_dev,
--
2.35.1
\
 
 \ /
  Last update: 2022-12-14 13:03    [W:0.309 / U:0.372 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site